Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ODC-441] Foadnh submodule go client #22

Merged
merged 40 commits into from
May 5, 2022
Merged

[ODC-441] Foadnh submodule go client #22

merged 40 commits into from
May 5, 2022

Conversation

foadnh
Copy link

@foadnh foadnh commented Apr 13, 2022 •
edited
Loading

🚋

Previous PR: #21
Next PR: #23

Changes included

Changes in comparison to the existing way

  • Fork Go client to a new repository and use git submodule instead of copying codes.

Notes

  • Since we have a fork of the client repo, no need to have it inside this repo. We can actually remove the submodule.

This was referenced Apr 13, 2022
Merged
Merged
@foadnh foadnh force-pushed the foadnh-submodule-go-client branch from d93f14c to 522af83 Compare April 13, 2022 02:11
@foadnh foadnh requested review from charlesverdad and atoolan April 13, 2022 04:23
@foadnh foadnh force-pushed the foadnh-submodule-go-client branch from 615f285 to 68edc11 Compare April 13, 2022 22:41
@foadnh foadnh force-pushed the foadnh-submodule-go-client branch from 68edc11 to b852f55 Compare April 13, 2022 22:51
@foadnh foadnh merged commit e66bb3c into foadnh-fresh-add-ci May 5, 2022
@foadnh foadnh deleted the foadnh-submodule-go-client branch May 5, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesverdad charlesverdad charlesverdad approved these changes

@atoolan atoolan Awaiting requested review from atoolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foadnh @charlesverdad