Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types #332

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Update types #332

merged 4 commits into from
Mar 19, 2024

Conversation

bosh-code
Copy link
Contributor

Update the types and JSDocs for this plugin.

Contains "breaking" changes for any users using typescript as some of the interface names have changed and the usage will need to be updated, however this should have no effect on code execution.

Happy to discuss feedback.

@WcaleNieWolny WcaleNieWolny requested a review from riderx March 15, 2024 18:36
@riderx
Copy link
Collaborator

riderx commented Mar 18, 2024

Hey thanks for the update, i wonder why did you removed the licence in the file?

@bosh-code
Copy link
Contributor Author

Hey thanks for the update, i wonder why did you removed the license in the file?

No worries, as long as you are shipping the license with the package, which you are, there's nothing more that needs to be done. Its not standard practice to include license docs at the beginning of source files.

@riderx
Copy link
Collaborator

riderx commented Mar 18, 2024

License is very important for the project.
This kind of thing cannot be done without discussion.
The current license requires this exact behavior to be done for the plugin.
Secondly, you removed only in one place, what is not really consistent.
So can you put it back ?

@riderx
Copy link
Collaborator

riderx commented Mar 18, 2024

Here is the link if you want to learn about MPL:
https://www.mozilla.org/en-US/MPL/2.0/FAQ/
CleanShot 2024-03-18 at 23 27 09@2x

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bosh-code
Copy link
Contributor Author

Sure no worries, added it back.

@riderx
Copy link
Collaborator

riderx commented Mar 19, 2024

thanks !

@riderx riderx merged commit a7a5868 into Cap-go:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants