Fix: Handle C++ exceptions in Windows Graphics Capture API #1178
+50
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CAP-DESKTOP-M5. The issue was that: GraphicsCapture API failure throws unhandled C++ exception across FFI boundary, corrupting Rust runtime and causing fatal crash.
CreateForMonitorandCreateForWindowcalls incatch_unwindto handle C++ exceptions thrown by the Graphics Capture API on Windows 10 build 18363.This fix was generated by Seer in Sentry, triggered by Richie. 👁️ Run ID: 1917985
Not quite right? Click here to continue debugging with Seer.