Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Windows, cross-platform copy, system theme... #179

Merged
merged 64 commits into from
Dec 9, 2024

Conversation

ItsEeleeya
Copy link
Contributor

@ItsEeleeya ItsEeleeya commented Nov 22, 2024

  • Use arboard clipboard-rs for cross-platform clipboard writes.
    (- Removes plugin-clipboard-manager)
  • Fix window bounds (Windows) to not include the window area's shadow
  • Minor fix to recording actors
  • Don't unwrap on prev-recordings window's cursor_position() as it might sometimes be an Err on windows.
  • prev-recordings on Chromium webviews have an issue where elements with a z-index don't respect the overflow style properly.
    Previous:

Other changes:

  • Show export progress on taskbar/dock icon
  • System theme support. Adds theme previews.
  • Fixed an issue where the logo on the main window would jump in size when dark mode was on.
  • Request user attention after an update has finished downloading.
  • Fix scrollbar colors not respecting app's theme. Use thin scrollbar

Fixed scrollbar style on Windows

  • New installer sidebar banner
    MSI installer banner

  • New macos-specific icon matching the rest of the system

## Known Issue (Windows-only)
After logging into the app and restarting, trying to open the settings window will freeze the app, likely an issue with how the setting's store is read. For now during development you need to remove the old store and log back in.
Magically Solved by @Brendonovich

Copy link

vercel bot commented Nov 22, 2024

@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@Brendonovich
Copy link
Member

Working well on macos for me, still need to test on windows

@ItsEeleeya
Copy link
Contributor Author

even after removing the previous store and logging back in, opening the settings freezes the entire app (including the frontend sometimes)
sreenshot of store.dat

@ItsEeleeya
Copy link
Contributor Author

@Brendonovich I updated the preparation script to work on windows. It now correctly adds the DLLs to the resources on Windows.
It defines a wix upgrade code as recommended by Tauri.
If the version includes anything other than integers, it'll get transformed on windows.
e.g: 0.3.3-beta.12 -> 0.3.3.12
stripDebugSymbols is macos only for now.

I had to update tauri-cli to 2.1.0 from 2.0.0-rc and after that for some reason Turbo doesn't seem to be able to build properly for me. It suddenly needed a new config and even then it was failing.
The pnpm-lock might be broken

tauri build and some plugins are also on rc, maybe these should be updated as well?

@ItsEeleeya
Copy link
Contributor Author

Preparation scrip is now fixed, the github CI prebuild script now uses it for creating the platform configs (haven't tested it on Github).
Installing the app now correctly moves the required ffmpeg DLLs to its location.
This PR now sets a fixed upgrade code for the WIX installer as recommended by Tauri, it's the same GUID that tauri crates with the current productName from the configs which you can see with the command: tauri inspect wix-upgrade-code

@Brendonovich Brendonovich merged commit 524dcda into CapSoftware:main Dec 9, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants