Udacity secure elb #468
Closed
Udacity secure elb #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we were over-riding this with an `APOLLO_haproxy_image` env var, but lets make it explicit. The new filtering haproxy.tmpl from 968f12f is only compatible with consul-template v0.9.0 or greater. - asteris/haproxy-consul uses consul-template v0.8.0 and there are reports that v0.9.0 is unstable. - udacity/haproxy-consul uses v0.10.0
- haproxy, as the public-facing gatekeeper, should only front for public services. Services like marathon and mesos are internal and should not be proxied - filter on consul "public" tag - add explicit backend for consul since elb healthchecks hit it via the haproxy_status frontend
- configure SSL termination at load balancers
- add redirect directive based on X-Forwarded-Proto (set by AWS ELB) basing the redirect on ssl_fc will result in a looping redirect since AWS ELB is terminating our SSL and haproxy only ever sees http traffc - reopen port 80 on the load balancer now that we have a safe redirect at the haproxy layer
|
Looks good to me. |
|
closing as we no longer use haproxy. will revisit this when traefik letsencrypt support lands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This secures the aws load balancer, only allowing TLS traffic, terminating at the load balancers.
Only 'public' -tagged services in consul will be exported; that means marathon, mesos etc aren't exposed to the world.
We are using udacity's version of haproxy-consul because we need to use v0.10.0 of consul-template
https://github.com/udacity/haproxy-consul