Sources rich medias improvements #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGambini
approved these changes
Nov 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements regarding rich medias
Using site_name to check website is not recommended. We extract it from website opengraph or <title> anchor and any website can set any value here.
Also a website like Facebook would always be listed as a video but a Facebook links can also target posts. We need Regexp here.
Some players have been disabled. As each one of them loads its little js bundle, it can be heavy if we have too much different players on the same page so we keep only the most popular. We may change this based on usage.
Sounds like
preloadingoption in ReactPlayer was about fixing a bug by playing video silently -not what we seek- and anyway it is already set to false by default. However, Facebook do preload (pre-fetch is more accurate) (part of) its content which is a no-go.So bye bye Facebook.
Fixed player size
Not directly linked to rich medias
Youtube-nocookie temporary rollback, see Support for youtube-nocookie.com cookpete/react-player#272
Remove youtube-regex which was using /g flag (wtf?)
@NGambini You can add commits to this pull request if you see missing or wrong stuff
Close #4