Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cheating class level 3 by copying level 2 activation #6643

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Fix cheating class level 3 by copying level 2 activation #6643

merged 4 commits into from
Nov 29, 2024

Conversation

tool4ever
Copy link
Contributor

Probably doesn't make sense if the trigger would still fire either.

Closes #6634

@tool4ever tool4ever added the Rules compliance Bringing the engine or cards closer to CR label Nov 28, 2024
Hanmac
Hanmac previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Hanmac Hanmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would try to move the ClassLevelUp check to conditions, but i think it is good enough for now

@tool4ever tool4ever merged commit 947d190 into Card-Forge:master Nov 29, 2024
1 check passed
@tool4ever tool4ever deleted the fix28 branch November 29, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanmac Hanmac Hanmac approved these changes

Assignees
No one assigned
Labels
Rules compliance Bringing the engine or cards closer to CR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When activating Carionette (Tempest) it remains in the graveyard
2 participants
@tool4ever @Hanmac