Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-2671: Add try-state hook to the elections pallet #1251

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

pmikolajczyk41
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 commented Jun 12, 2023

Description

This is the first PR introducing try-state hook to our pallets. Hopefully, more to come.

Why?

try-state is a similar concept to try-runtime. Basically, we can put all (storage) invariant checks into a hook and trigger them from anywhere we need. By default, they can be called from most of try-runtime commands, like follow-chain. More info: https://forum.polkadot.network/t/testing-complex-frame-pallets-discussion-tools/356#try-runtime-follow-chain-trystate-4

Local testing

I have broken some of the checks in ensure_validators_are_ok function and then:

$ cargo build --release --features try-runtime
$ ./scripts/run_nodes.sh -b false
$ ./target/release/aleph-node try-runtime --runtime existing --chain /tmp/chainspec.json follow-chain --uri ws://localhost:9944 --keep-connection

Note: Cardinal-Cryptography/substrate#39 is required for this scenario.

Type of change

  • New feature (non-breaking change which adds functionality)

@pmikolajczyk41 pmikolajczyk41 added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit 932de70 Jun 13, 2023
@pmikolajczyk41 pmikolajczyk41 deleted the a0-2671-elections-check branch June 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants