A0-2671: Add try-state hook to the elections pallet #1251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first PR introducing
try-state
hook to our pallets. Hopefully, more to come.Why?
try-state
is a similar concept totry-runtime
. Basically, we can put all (storage) invariant checks into a hook and trigger them from anywhere we need. By default, they can be called from most oftry-runtime
commands, likefollow-chain
. More info: https://forum.polkadot.network/t/testing-complex-frame-pallets-discussion-tools/356#try-runtime-follow-chain-trystate-4Local testing
I have broken some of the checks in
ensure_validators_are_ok
function and then:$ cargo build --release --features try-runtime $ ./scripts/run_nodes.sh -b false $ ./target/release/aleph-node try-runtime --runtime existing --chain /tmp/chainspec.json follow-chain --uri ws://localhost:9944 --keep-connection
Note: Cardinal-Cryptography/substrate#39 is required for this scenario.
Type of change