Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-1847: Add support for disuniting aura and alephbft #71

Merged

Conversation

youPickItUp
Copy link

Testing section says

However it’s important to also test it with a local node, to see if it also works with non-trivial settings concerning both commitees (on testnet both committees are currently the same, so it’s not interesting).

I wasn't able to test it localy for interesting settings. @kostekIV could you guide me how to do it, or test it yourself?

Copy link

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make a sudo call Elections.change_validators that can be done by tab https://test.azero.dev/#/extrinsics (obviously use the local one :P). Change the committee seats to have different (smaller )values for non_reserved_finality_committe. Im ooo today If this is not helpful :P I will test it tomorrow

packages/react-hooks/src/useAlephBFTCommittee.ts Outdated Show resolved Hide resolved
@youPickItUp youPickItUp removed the request for review from Marcin-Radecki July 6, 2023 13:14
@youPickItUp youPickItUp requested a review from jalooc July 6, 2023 14:24
@youPickItUp youPickItUp added this pull request to the merge queue Jul 11, 2023
Merged via the queue into alephzero with commit e934011 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants