feat: add OG Meta Tag #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helloheesu
suggested changes
Jan 16, 2023
| <meta | ||
| name="description" |
There was a problem hiding this comment.
description, og:description 둘 다 있어야합니다.
둘 중 하나 고르라면 오히려 description이 있어야합니다....
og 를 지원하는 많은 서비스들이 description을 fallback으로 삼는 경우가 많지만
구글 등 SEO는 og는 안 보기 때문입니다.
| @@ -1,3 +0,0 @@ | |||
| # https://www.robotstxt.org/robotstxt.html | |||
There was a problem hiding this comment.
robots.txt 를 일부러 지울 필요는...??
지운 의도가 무엇인가요?
There was a problem hiding this comment.
불필요하다고 생각했는데 생각해 보니 일부러 지울 필요 없었던 것 같습니다 다시 살릴게요!
helloheesu
reviewed
Jan 30, 2023
| <meta property="og:title" content="Supernova Faucet" /> | ||
| <meta property="og:description" content="Faucet is a tool for get testnet tokens in order to test Supernova" /> | ||
| <meta property="og:site_name" content="Supernova" /> | ||
| <meta property="og:image" content="http://faucet.dev-supernova.xyz/og.png" /> |
helloheesu
force-pushed
the
feat/ogTag
branch
from
1800421
to
6e57ead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Carina-Labs에 없어서 일단 환경변수로 빼지 못했음도메인 주소환경변수로 빼야될 것 같음Head안에meta tag추가하는 방식 채택함https://도메인 주소/이미지 경로이렇게 활용해야 됨How to Test