Add datablock parsing for linear acceleration and angular velocity #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linguini1
reviewed
May 16, 2024
linguini1
reviewed
May 16, 2024
There was a problem hiding this comment.
Quick af and clean as always! Write some test cases when you have time using generated output from packager and if they work, I'll approve for merge. IMO looks just fine, but I want to wait until tests are ready to merge.
Also some fun workflow errors to resolve.
linguini1
previously approved these changes
May 16, 2024
linguini1
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the data blocks for parsing linear acceleration and angular velocity