refactor(back-end): method overloads should be adjacent

CarlosPavajeau · Apr 29, 2021 · b8c6cea · b8c6cea
1 parent a1e87f8
commit b8c6cea
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 26 deletions.
diff --git a/Kaizen/Controllers/EmployeesController.cs b/Kaizen/Controllers/EmployeesController.cs
@@ -66,6 +66,19 @@ public async Task<ActionResult<IEnumerable<EmployeeChargeViewModel>>> EmployeeCh
             return Ok(_mapper.Map<IEnumerable<EmployeeChargeViewModel>>(employeeCharges));
         }
 
+        [HttpPost("[action]")]
+        [Authorize(Roles = "Administrator")]
+        public async Task<ActionResult<EmployeeChargeViewModel>> EmployeeCharges(
+            [FromBody] EmployeeChargeInputModel employeeChargeInputModel)
+        {
+            EmployeeCharge employeeCharge = _mapper.Map<EmployeeCharge>(employeeChargeInputModel);
+
+            _employeesRepository.Insert(employeeCharge);
+            await _unitWork.SaveAsync();
+
+            return _mapper.Map<EmployeeChargeViewModel>(employeeCharge);
+        }
+
         [HttpGet("{id}")]
         public async Task<ActionResult<EmployeeViewModel>> GetEmployee(string id)
         {
@@ -168,19 +181,6 @@ public async Task<ActionResult<EmployeeViewModel>> PostEmployee(EmployeeInputMod
             return _mapper.Map<EmployeeViewModel>(employee);
         }
 
-        [HttpPost("[action]")]
-        [Authorize(Roles = "Administrator")]
-        public async Task<ActionResult<EmployeeChargeViewModel>> EmployeeCharges(
-            [FromBody] EmployeeChargeInputModel employeeChargeInputModel)
-        {
-            EmployeeCharge employeeCharge = _mapper.Map<EmployeeCharge>(employeeChargeInputModel);
-
-            _employeesRepository.Insert(employeeCharge);
-            await _unitWork.SaveAsync();
-
-            return _mapper.Map<EmployeeChargeViewModel>(employeeCharge);
-        }
-
         private static string GetEmployeeRole(Employee employee)
         {
             return employee.EmployeeCharge.Id switch

diff --git a/Kaizen/Controllers/ServicesController.cs b/Kaizen/Controllers/ServicesController.cs
@@ -57,6 +57,20 @@ public async Task<ActionResult<IEnumerable<ServiceTypeViewModel>>> ServiceTypes(
             return Ok(_mapper.Map<IEnumerable<ServiceTypeViewModel>>(serviceTypes));
         }
 
+        [Authorize(Roles = "Administrator")]
+        [HttpPost("[action]")]
+        public async Task<ActionResult<ServiceTypeViewModel>> ServiceTypes(
+            [FromBody] ServiceTypeInputModel serviceTypeInputModel)
+        {
+            ServiceType serviceType = _mapper.Map<ServiceType>(serviceTypeInputModel);
+
+            _servicesRepository.Insert(serviceType);
+
+            await _unitWork.SaveAsync();
+
+            return _mapper.Map<ServiceTypeViewModel>(serviceType);
+        }
+
         [HttpGet("[action]/{id}")]
         [AllowAnonymous]
         public async Task<bool> CheckExists(string id)
@@ -116,19 +130,6 @@ public async Task<ActionResult<ServiceViewModel>> PostService([FromBody] Service
             return _mapper.Map<ServiceViewModel>(service);
         }
 
-        [Authorize(Roles = "Administrator")]
-        [HttpPost("[action]")]
-        public async Task<ActionResult<ServiceTypeViewModel>> ServiceTypes([FromBody] ServiceTypeInputModel serviceTypeInputModel)
-        {
-            ServiceType serviceType = _mapper.Map<ServiceType>(serviceTypeInputModel);
-
-            _servicesRepository.Insert(serviceType);
-
-            await _unitWork.SaveAsync();
-
-            return _mapper.Map<ServiceTypeViewModel>(serviceType);
-        }
-
         [Authorize(Roles = "Administrator")]
         [HttpDelete("{id}")]
         public async Task<ActionResult<ServiceViewModel>> DeleteService(string id)