Fixed up dotsettings file, changed to some c# 7 features #18
Conversation
| @@ -22,7 +22,7 @@ private IValidator FindValidator(Type type) | |||
| var fullType = CreateValidatorType(type); | |||
|
|
|||
| var available = this.validators | |||
| .Where(validator => fullType.GetTypeInfo().IsAssignableFrom(validator.GetType())) | |||
| .Where(validator => fullType.GetTypeInfo().IsInstanceOfType(validator)) | |||
There was a problem hiding this comment.
Did you run tests for this. I saw Rider suggest this but I'm not sure it does what I want
There was a problem hiding this comment.
Did I run tests before sending a PR... it's like you don't even know me. (Yes, the tests pass)
There was a problem hiding this comment.
I need to get a CI build setup on this repo. That's your next PR 😄
There was a problem hiding this comment.
AppVeyor -> New Project, right?
There was a problem hiding this comment.
If you want windows. There's others though https://github.com/marketplace/category/continuous-integration
There was a problem hiding this comment.
Unfortunately for you, it will have to be the repo admin that does it. Unlucky.
|
It's ok I can add you
…On 4 October 2017 at 16:30, Joe Stead ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/DefaultValidatorLocator.cs
<#18 (comment)>:
> @@ -22,7 +22,7 @@ private IValidator FindValidator(Type type)
var fullType = CreateValidatorType(type);
var available = this.validators
- .Where(validator => fullType.GetTypeInfo().IsAssignableFrom(validator.GetType()))
+ .Where(validator => fullType.GetTypeInfo().IsInstanceOfType(validator))
Unfortunately for you, it will have to be the repo admin that does it.
Unlucky.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGaphN_ivH7OmTWfArzOmyR0MjJqFnNks5so6SJgaJpZM4PtsRR>
.
|
JoeStead
force-pushed
the
language-moderniser
branch
from
04082ec to
f6bd2a3
Compare
JoeStead
force-pushed
the
language-moderniser
branch
from
f6bd2a3 to
12517b4
Compare
| RequestDelegate requestDelegate = httpContext => | ||
| handler(httpContext.Request, httpContext.Response, httpContext.GetRouteData()); | ||
| this.Get(path, requestDelegate); | ||
| Task RequestDelegate(HttpContext httpContext) => handler(httpContext.Request, httpContext.Response, httpContext.GetRouteData()); |
There was a problem hiding this comment.
An inline function. C# 7 thing. Makes working with functions and the like way simpler
There was a problem hiding this comment.
There was a reason I did this, if you asked me 2 days ago I would have told you
There was a problem hiding this comment.
Perf: dotnet/roslyn#3911
The dot settings file was still using C# 5.0 for some reason, I removed this and: