-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reusable workflows #2
base: main
Are you sure you want to change the base?
Conversation
Could we just rename this repo or dos that have a conflict with other stuff? |
I didn't know renaming repos was an option, that's great. No dependency so far on the repo name, go ahead and I'll update this PR accordingly. Thanks! |
All done 🙂 |
All good from my side now. As an aside, I couldn't find another repo with projects taking a NuGet dependency on Carter, they all seem to use Git submodules. Do we plan on changing this? |
Thanks, I pushed an update that points to the right repository. |
CarterCommunity/Carter#311
Instead of copying the workflow file around, this sets us up to use reusable workflows, where a workflow can call another another one, even if it's defined in another repository.
In our case, this means the following:
One aspect that is not ideal is that we (based on my suggestion) named this repository
.github
, and GitHub expects workflow files to live in the.github/workflows
directory.This means that, in the other repos, when we want to call the workflow in this repository, we'll have a double
.github
segment in the path, which may look weird and/or confuse people:If we don't like this, I think it's easy enough to create another repo that we can call
reusable-workflows
or something along those lines, and get rid of this one.Up to you.