Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes in tests to work in docker-dev-env #1180

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juanrmn
Copy link
Member

@juanrmn juanrmn commented Jun 24, 2020

It works along with some changes in this PR to docker-dev-env:

  • docker-compose/docker-compose.yml -> windshaft service section, mounts lib and test volumes from local folder.
  • docker-compose/mounts/windshaft_test.js -> tests config, also mounted in main docker-compose.yml file.
  • (docker-compose/CartoDB-SQL-API_lib_server.js.patch) -> For Cartoframes, redirect Maps-API requests.

@dgaubert
Copy link
Contributor

Yeah, nice work @juanrmn. it makes sense.

Even I'd go further and I'd require both Redis and Postgres up and running in their respective ports.

Thanks for sharing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants