Fix http status on database authentication errors (#94)

NEWS.md

@@ -2,6 +2,7 @@ Version 0.14.3-dev
 2013-MM-DD
 
  - Return CORS headers when creating layergroups via GET (#92)
+ - Fix http status on database authentication error (#94)
 
 Version 0.14.2
 2013-11-08

lib/windshaft/server.js

@@ -445,8 +445,15 @@ console.log("getRenderer ERROR: "); console.dir(err);
                     if ( -1 != errMsg.indexOf('permission denied') ) {
                       statusCode = 401;
                     }
+                    else if ( -1 != errMsg.indexOf('authentication failed') ) {
+                      statusCode = 401;
+                    }
                     else if ( -1 != errMsg.indexOf('does not exist') ) {
-                      statusCode = 404;
+                      if ( -1 != errMsg.indexOf(' role ') ) {
+                        statusCode = 401; // role 'xxx' does not exist
+                      } else {
+                        statusCode = 404;
+                      }
                     }
 
                     // Rewrite mapnik parsing errors to start with layer number

test/acceptance/server.js

@@ -479,7 +479,7 @@ suite('server', function() {
             method: 'GET'
         },{
         }, function(res) {
-          assert.equal(res.statusCode, 404, res.statusCode + ( res.statusCode != 200 ? ( ": " + res.body ) : '' ));
+          assert.equal(res.statusCode, 401, res.statusCode + ( res.statusCode != 200 ? ( ": " + res.body ) : '' ));
           // TODO: also test that a new request with no overrideDBUser gets permission to access the tile ?
           done();
         });