Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message with unknown text-face-name at POST /layergroup time #93

Closed
strk opened this issue Nov 13, 2013 · 4 comments
Closed

No error message with unknown text-face-name at POST /layergroup time #93

strk opened this issue Nov 13, 2013 · 4 comments
Assignees
Labels
Milestone

Comments

@strk
Copy link
Contributor

strk commented Nov 13, 2013

Missing font face doesn't currently generate an error at layergroup creation time, unless geometries happen to fall in the "test tile" (CartoDB/Windshaft-cartodb#90)

It turns out there's a mapnik option to enforce text face checking at map load time (mapnik/mapnik#1791 (comment)).
We want to use that, for better error reporting. This will depend on tilelive-mapnik.

@strk
Copy link
Contributor Author

strk commented Nov 13, 2013

So it looks like the strict parameter in mapnik loader is hardcoded to false in tilelive-mapnik, so this would still hold us back to our own fork. Filed a ticket for the future in tilelive-mapnik: mapbox/tilelive-mapnik#74

@strk
Copy link
Contributor Author

strk commented Nov 25, 2013

For the record: switching to "strict" map loading resulted in some previously accepted style to become invalid.
See CartoDB/Windshaft-cartodb#93 for one example.

@strk
Copy link
Contributor Author

strk commented Nov 28, 2013

Reopening to deal with the backward compatibility issue. There's hope to do this in a different way: mapbox/carto#242

@strk
Copy link
Contributor Author

strk commented Nov 28, 2013

Closing again, after all the bug was fixed in 1.14.3, so the backward compatibility issue will be taken care of by #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant