Ensure text-face-name errors raise at layergroup creation time

Closes #93, includes testcase.
Required change in tilelive-mapnik (our fork)

NEWS.md

@@ -3,6 +3,7 @@ Version 0.14.3-dev
 
  - Return CORS headers when creating layergroups via GET (#92)
  - Fix http status on database authentication error (#94)
+ - Ensure bogus text-face-name error raises at layergroup creation (#93)
 
 Version 0.14.2
 2013-11-08

lib/windshaft/render_cache.js

@@ -307,6 +307,9 @@ module.exports = function(timeout, mml_store, mapnik_opts) {
                     query: query,
                     protocol: 'mapnik:',
                     slashes: true,
+                    // Trigger font errors at load time, see
+                    // https://github.com/CartoDB/Windshaft/issues/93
+                    strict: true,
                     xml: data,
                     mml: {
                         format: params.format

package.json

@@ -25,7 +25,7 @@
         "generic-pool": "~2.0.3",
         "express": "~2.5.11",
         "tilelive": "~4.4.2",
-        "tilelive-mapnik": "git://github.com/Vizzuality/tilelive-mapnik.git#5908346",
+        "tilelive-mapnik": "git://github.com/Vizzuality/tilelive-mapnik.git#0.5.0-cdb2",
         "mapnik": "~0.7.17",
         "lru-cache": "~2.3.0"
     },

test/acceptance/multilayer.js

@@ -1017,6 +1017,32 @@ suite('multilayer', function() {
       });
     });
 
+    // See https://github.com/CartoDB/Windshaft/issues/94
+    test("unknown text-face-name", function(done) {
+
+      var layergroup =  {
+        version: '1.0.1',
+        layers: [
+           { options: {
+               sql: "select 1.0 as n, 'SRID=3857;POINT(0 0)'::geometry as the_geom",
+               cartocss: '#s { text-name: [n]; text-face-name: "bogus"; }',
+               cartocss_version: '2.1.0',
+             } }
+        ]
+      };
+      assert.response(server, {
+          url: '/database/windshaft_test/layergroup',
+          method: 'POST',
+          headers: {host: 'localhost', 'Content-Type': 'application/json' },
+          data: JSON.stringify(layergroup)
+      }, {}, function(res) {
+          assert.equal(res.statusCode, 400, res.statusCode + ': ' + res.body);
+          var parsedBody = JSON.parse(res.body);
+          assert.deepEqual(parsedBody, {"errors":["style0: Failed to find font face 'bogus'"]});
+          done();
+      });
+    });
+
     ////////////////////////////////////////////////////////////////////
     //
     // OPTIONS LAYERGROUP