-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Animation Controls widget #634
Add Animation Controls widget #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I feel like the Bridge code could be extracted to a common place since so much is shared between this and the time series.
...ges/components/src/components/as-animation-controls-widget/as-animation-controls-widget.scss
Outdated
Show resolved
Hide resolved
...ges/components/src/components/as-animation-controls-widget/as-animation-controls-widget.scss
Outdated
Show resolved
Hide resolved
...ges/components/src/components/as-animation-controls-widget/as-animation-controls-widget.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/as-range-slider/slider/as-range-slider.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/as-range-slider/slider/as-range-slider.tsx
Show resolved
Hide resolved
packages/components/src/components/as-range-slider/slider/as-range-slider.spec.ts
Outdated
Show resolved
Hide resolved
packages/components/src/components/as-range-slider/track/as-range-slider-bar.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/as-range-slider/slider/as-range-slider.tsx
Outdated
Show resolved
Hide resolved
…t/as-animation-controls-widget.scss Co-Authored-By: Román Jiménez <drrouman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more things I saw
...ages/components/src/components/as-animation-controls-widget/as-animation-controls-widget.tsx
Outdated
Show resolved
Hide resolved
…t/as-animation-controls-widget.scss Co-Authored-By: Román Jiménez <drrouman@gmail.com>
…ange-slider.tsx Co-Authored-By: Román Jiménez <drrouman@gmail.com>
Co-Authored-By: Román Jiménez <drrouman@gmail.com>
…ange-slider.spec.ts Co-Authored-By: Román Jiménez <drrouman@gmail.com>
Have we considered adding the timestep visually (over or under the range slider)? I think we should. With that piece, I think we cover a much higher number of use cases. Some ideas we could use:
What do you think? |
I think the idea was to keep it simple. Having it on the scrubber makes it tricky to format (overflow on the sides). Also I don't know if the range sliders supports having it elsewhere. We already have some things to format dates due to the as-time-series-widget (it receives a format as per d3-time-format). |
I like the idea, actually there're other things it'd be great to have, like showing the current value of the animation. As Román says, we idea is to keep it simple now and create all the widgets, see how they work together, and then improve them. It'd also be great if the design team could be involved, but I'd do that in the next iteration. |
@elenatorro @rjimenezda I was talking about 'current value of the animation' indeed 😄 , but it's clear that I didn't explain myself correctly. I aggree with not adding it now, in this first version, but I think that displaying the date will be eventually required. Let's wait then. |
I just wanted to chime in that I agree with @VictorVelarde and think it's important for the next iteration of this widget to have the current timestamp (or number if animating on a numerical field). This helps the person viewing the map and interacting with it to understand the when and where of the events in the data. I also love @rjimenezda's idea of having a formatting string so the user can control how the timestamp (or number) is shown on the map. |
Fix CartoDB/cartoframes#812
Add a simple Animation Controls widget and its VL Bridge connector