Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change eval methods for those expressions that may depend on multiple features #1348

Open
elenatorro opened this issue May 21, 2019 · 1 comment
Assignees
Milestone

Comments

@elenatorro
Copy link
Contributor

Context

.eval methods are used internally to evaluate a feature from an expression, for example, to get the "legend data" (through .getLegendData). Not all the methods need to evaluate a feature (for example, globalAggregation). However, there are some cases where there could be more than one feature to evaluate. For instance, in all the binary expressions (mul, add, sub...) evaluate two features.

To Do

We have to fix all the eval methods that require in two or more features to be evaluated. This will also imply to test those methods to build legends.

@elenatorro elenatorro changed the title Change eval methods for those expressions that may depend in multiple features Change eval methods for those expressions that may depend on multiple features Jun 20, 2019
@elenatorro
Copy link
Contributor Author

Note: it currently has low priority but this is a must if we want to include bivariate legends in CARTOframes.

@elenatorro elenatorro added this to the Next milestone Jun 20, 2019
@elenatorro elenatorro self-assigned this Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants