Change eval methods for multiple feature #1376
Conversation
| let content = ''; | ||
|
|
||
| legends.data.forEach((legend) => { | ||
| const colorHex = rgbToHex(legend.value); |
There was a problem hiding this comment.
@elenatorro I think we can now remove this rgbToHex thing, and just usa rgba as in feature-and-legend-opacity.html example
There was a problem hiding this comment.
I would probably move this 'debug' example to public ones, what do you think? Or maybe we should do a small blog post?
There was a problem hiding this comment.
Totally! I'd like to have this in a separate task (since this one is a bit big), and it'd be great to have more than one example (but not too much, I mean, like two or three). At leas this one and another one that combines with and color properties.
There was a problem hiding this comment.
Fair enough. We can keep the rgbToHex if it is just a debug example.
| @@ -1,4 +1,11 @@ | |||
| import { And, Or, Equals, NotEquals, LessThan, LessThanOrEqualTo, GreaterThan, GreaterThanOrEqualTo } from '../renderer/viz/expressions/binary'; | |||
| import GreaterThan from '../renderer/viz/expressions/binary/GreaterThan'; | |||
There was a problem hiding this comment.
Why this small refactor here? Was it maybe based on some tooling?
There was a problem hiding this comment.
Oh, I see it now... you deleted the binary.js, much better
| }); | ||
|
|
||
| describe('NUMBER_AND_COLOR_TO_COLOR', () => { | ||
| testValue('mul', 10, s.rgba(255, 15, 12, 1), { r: 10, g: 1, b: 0, a: 1 }); |
There was a problem hiding this comment.
When does this NUMBER * COLOR is useful? do you know any example?
There was a problem hiding this comment.
Actually, no, but it's been there for a while and I think there was an example. I'll do a bit of research.
| }); | ||
| } | ||
|
|
||
| describe('mul', () => { |
There was a problem hiding this comment.
Shouldn't we split also the tests into different files? Especially now that we have 1 file per operation.
There was a problem hiding this comment.
Ok, I agree, I'll change that :)
Related issue #1348
This PR adds:
valueandevalfor binary operation expressionsgetLegendDatafor binary operation expressionsThis means that we can also have Bivariate legends in Airship and CARTOframes.
Nice to have: