Disable geocoding options in on-premise #1500
Conversation
Ticket related #1227 Disable geocoding by (city names, admin. regions, postal codes and ip) if the feature flag ‘on_premise) is enabled. Also, I have deleted lib/assets/test/spec/test_runner.html because it wasn’t being used.
| @@ -1,32 +0,0 @@ | |||
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" | |||
There was a problem hiding this comment.
This file shouldn't be committed :S
There was a problem hiding this comment.
Sorry, but I understood (at #frontend chat talk with @viddo ) that we had to delete that file because it wasn't being used.
There was a problem hiding this comment.
hahaha, sorry mate, my bad, I thought you were adding it!, go ahead!
Fix naming as we discussed (flag specific) https://github.com/CartoDB/cartodb-onpremise/issues/48
|
Please, @javisantana , could you review it? It's using new naming as we discussed ( https://github.com/CartoDB/cartodb-onpremise/issues/48 ) |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "browserify_debug": true, | |||
| "browserify_watch": true, | |||
| "browserify_watch": false, | |||
There was a problem hiding this comment.
not sure if this change should go here
There was a problem hiding this comment.
This value matches master though, is this branch up-to-date?
There was a problem hiding this comment.
I think that no, so I won't commit this file
Also it was removed the alignment (as it was before)
|
@javisantana why did Jenkins fail? _SpecRunner passed correctly. |
|
@Xatpy looks like a problem with clinker itself: http://clinker.cartodb.net/jenkins/job/CartoDB-PR-testing/1089/console |
|
retest this please |
|
@javisantana I retested it, but same result. I don't understand it, because I didn't commit cartodb.css Could be |
|
@Xatpy dunno, but try to remove that change (you finally didn't do it) |
|
retest this please |
|
Mail sent to support@clinkerhq.zendesk.com asking for details about this. |
|
retest this please |
|
I close this pr because it was done in this other PR The reason is because there were a lot of conflicts here, and I preferred to start in an updated branch. |
Ticket related #1227
Disable geocoding by (city names, admin. regions, postal codes and ip)
if the feature flag ‘georef_disabled' is enabled.
Also, I have deleted lib/assets/test/spec/test_runner.html because it
wasn’t being used.
Please, @javisantana @xavijam @viddo could you review it? Thanks!