Email settings section in Account page to manage notifications #15933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial style for the row in a new Email Settings category, using harcoded data
WIP, without having any real interaction with data or api
Connect current <Save changes> button to launch both updateUser + updateNotifications settings. No hitting the real API yet.
To manage getting & putting configuration related to new email notification
VictorVelarde
force-pushed
the
email-settings
branch
4 times, most recently
from
d5ef1af to
1244d41
Compare
VictorVelarde
force-pushed
the
email-settings
branch
from
1244d41 to
fc3341b
Compare
VictorVelarde
changed the title
VictorVelarde
force-pushed
the
email-settings
branch
from
814af19 to
4f82f42
Compare
|
Deploying to staging... |
|
Once we have it, this could be a simple acceptance: https://email-settings.carto-staging.com/
|
|
Confirmed, it's working perfectly, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To manage if the user wants email enabled for certain notifications (currently just
do_subscriptions) from the /account page.It adds the frontend to this previous API PR: #15930