Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck Gl as peer dependency #16413

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Conversation

padawannn
Copy link
Contributor

No description provided.

@padawannn padawannn requested a review from a team April 20, 2022 13:01
@@ -1,6 +1,6 @@
{
"name": "cartodb-ui",
"version": "1.0.0-assets.274-10",
"version": "1.0.0-assets.274-11",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this name? should we change it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it's needed anymore. You probably changed it because it was always changed, but nobody remembers why it started ?

@VictorVelarde VictorVelarde requested review from zbigg and VictorVelarde and removed request for a team April 20, 2022 15:32
Copy link

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padawannn padawannn merged commit 6af35db into cloud-native Apr 20, 2022
@padawannn padawannn deleted the cloud-native-peer-dependencies branch April 20, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants