Fetching data in geocodeLatAndLng() and fixing test #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, @viddo , could you check it? |
|
👍 don't forget to update NEWS and bump version |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
Xatpy
added a commit
that referenced
this pull request
Mar 11, 2015
…code_by_Lon/Lat Fetching data in geocodeLatAndLng() and fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. ticket #2518: Geocoding by Lon/Lat doesn't refresh the table automatically
The issue was that the table hadn't been fetched when it was georeferenced by Lon/Lat.
This PR also fixed that test (should add lat and lon to the_geom if georeferenced by column)
Demo-gif:
