Purge varnish items with "cdb_tablemetadata" channel on table update #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes CartoDB#296 Ensures that queries against CDB_TableMetadata for "last_updated" (for example from Windshaft-CartoDB) are correctly invalidated. You need to run bundle exec rake cartodb:db:load_functions to upgrade, as already noted in the UPGRADE file.
|
Why is rake cartodb:db:load_functions necessary for a change in the model? |
|
It is needed for a change in the database_model. In this specific case it is needed as it calls --strk; |
|
Actually it's only necessary to load the varnish invalidation function. |
|
Good, anyway the point is that since "load_functions" is already documented in https://github.com/CartoDB/cartodb/blob/v2.5.6/UPGRADE, there should be no need to note in the NEWS file about the need to run load_varnish_invalidation_function (implied by the former) |
|
For the record: that commit ended up in release/2.6.0 -- this pull request has to be closed once it hits master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #296
Ensures that queries against CDB_TableMetadata for "last_updated"
(for example from Windshaft-CartoDB) are correctly invalidated.
You need to run bundle exec rake cartodb:db:load_functions to upgrade,
as already noted in the UPGRADE file.