Add new fields to metadata modal

[viddo]

Fixes #4803

While I didn't have any mockups this time I simply added the new fields between desc and tags, i.e.:

Empty values/placeholders:

Licence dropdown:

@saleiva @josecruz OK? Or did you have another idae on how it should look?
@csobier and @brittanymicek for copy (see the placeholder texts above). also notice the "-" for the non-selected license perhaps we should have some text there instead?

@javierarce can you do the code review, please?

[javierarce]

👍 Looks good to me.

[saleiva]

That icon on the dropdown should be the default one.
Also I'd not repeat 3 times the md thingym I propose we leave it just under
the description
On Aug 13, 2015 5:31 PM, "Javier Arce" notifications@github.com wrote:

[image: 👍] Looks good to me.

—
Reply to this email directly or view it on GitHub
#5016 (comment).

[josecruz]

What's the meaning of this right icon?

[csobier]

I can suggest some text for the License field once we know what the icon indicates? Is it a tooltip? It it mandatory? Otherwise, here is my best guess:
"Select the type of license required for copying, distributing, or modifying this dataset"

Additionally, I would keep the field descriptions consistent- either all statements or all questions. Typically, product UI field descriptions are statements so the Source description should say something like "Enter the source of the data"

[viddo]

The icon is a mistake, I suspect the change of the icons recently (should be the default dropdown/chevron icon), fixed now:

@csobier It's a standard dropdown (see new screenshot above). It's value is optional (thus the "-" option at the top for, which I was asking if we should replace that with some text instead? Apart from that, updated the placeholders, I'll keep that guideline in mind for the next forms I'll do 👍

[saleiva]

The margin between the inputs should be the same than between the first and
the second one.
On Aug 14, 2015 3:31 PM, "Nicklas Gummesson" notifications@github.com
wrote:

The icon is a mistake, I suspect the change of the icons recently (should
be the default dropdown/chevron icon), fixed now:

[image: screen shot 2015-08-14 at 15 27 49]
https://cloud.githubusercontent.com/assets/978461/9274852/6067ef30-4299-11e5-9f23-20bc20692259.png

@csobier https://github.com/csobier It's a standard dropdown (see new
screenshot above). It's value is optional (thus the "-" option at the top
for, which I was asking if we should replace that with some text instead?
Apart from that, updated the placeholders, I'll keep that guideline in mind
for the next forms I'll do [image: 👍]

—
Reply to this email directly or view it on GitHub
#5016 (comment).

[viddo]

[saleiva]

🇪🇸
On Aug 14, 2015 5:27 PM, "Nicklas Gummesson" notifications@github.com
wrote:

[image: screen shot 2015-08-14 at 17 25 48]
https://cloud.githubusercontent.com/assets/978461/9277328/9e61c71a-42a9-11e5-9d8a-9cae239fb685.png

—
Reply to this email directly or view it on GitHub
#5016 (comment).

[viddo]

I'll go ahead and merge this, if you want any additional changes just create a new issue and assign me :)