Fix submodule not being included #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafatower
suggested changes
Jan 15, 2018
CHANGELOG.carto.md
Outdated
| @@ -1,5 +1,12 @@ | |||
| # CARTO node-mapnik changelog | |||
|
|
|||
| ## 3.6.2-carto.2 | |||
|
|
|||
| **Release date**: 2018-01-15 | |||
There was a problem hiding this comment.
I would not set the release that yet, but "stub" the next release. We will probably pull more changes in that one.
There was a problem hiding this comment.
I was hoping to use carto releases instead of my own fork but I don't know if that's possible even with this fix, so I'll leave the date as 2018-XX-XX for now.
Algunenano
force-pushed
the
v3.6.2-carto_FIX_Makefile
branch
from
168f078
to
1bc7b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems I removed it with the cherry-pick so building the npm package from source it's currently impossible: