Fixed some bugs in addInTheRightPosition function #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carto-frontend/web-sdk/knlyezevq |
VictorVelarde
force-pushed
the
sergioclebal/fix-addInTheRightPosition-fn-bug
branch
from
ff3a829 to
cefb988
Compare
VictorVelarde
force-pushed
the
sergioclebal/fix-addInTheRightPosition-fn-bug
branch
from
6b2a51d to
f886acb
Compare
|
Just for the record, at the beginning a flip was made on the meaning of 'before/after', but we then decided to go after a rename, cause ‘before’ and ‘after’ weere not very clear terms, using ‘overLayerId’ & ‘underLayerId’ as a better one now |
VictorVelarde
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function to add the layer in the right position (addInTheRightPosition) wasn't working properly.