Feature/ch100368/performance getfeatures #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com:CartoDB/web-sdk into feature/ch100368/performance-getfeatures
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carto-frontend/web-sdk/p579u9twf |
Base automatically changed from
feature/ch99194/web-sdk-implement-new-bqsource
to
develop
August 28, 2020 10:46
| @@ -457,13 +464,18 @@ export class Layer extends WithEvents implements StyledLayer { | |||
| dimensions.forEach(dimension => this._source.addField(dimension)); | |||
| columns.forEach(aggregatedColumn => this._source.addAggregatedColumn(aggregatedColumn)); | |||
|
|
|||
| return this.replaceDeckLayer(); | |||
| if (this._source.needsInitialization) { | |||
…:CartoDB/web-sdk into feature/ch100368/performance-getfeatures
| @@ -3,9 +3,10 @@ import { Layer, Source } from '@/viz'; | |||
| import { Credentials } from '@/auth'; | |||
| import { Filter, ColumnFilters, SpatialFilters } from '@/viz/filters/types'; | |||
| import { AggregationType } from '@/data/operations/aggregation/'; | |||
| import { debounce } from '@/viz/core/utils'; | |||
VictorVelarde
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
🚀 Well done!
Please add a note to changelog, like this and merge when you want:
Added
- Better performance in
Layer, with a debounced approach to DATA_CHANGED event (#130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance: