Added support for DriverManager Properties #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on factory.
Ran into various issues with Oracle and to work around them, I needed to set some arbitrary
driver properties. The DriverManager was buried in DBConfiguration. I created
a jobconf prefix "dbmigrate.driver." that lets you set arbitrary configuration values
in the job conf that will be used as driver properties. I then added convenience
methods all the way up to DBMigrateTap / DBOptions supporting class.
In clojure, we can now do something like this:
(let [opts (new cascading.dbmigrate.tap.DBMigrateTap$Options)]
(set! (. opts :minId) (long min)))
(set! (. opts :maxId) (long max)))
(set! (. opts :driverProps) {"oracle.jdbc.J2EE13Compliant" "true"})
opts))
you should also be able to add
{"dbmigrate.driver.oracle.jdbc.J2EE13Compliant" "true"}
to your job-conf.clj file if you choose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for setting driver manager properties and passing them to the java driver manager (something that was necessary for migrating from Oracle).
I ran into various issues with Oracle and to work around them, I needed to set some arbitrary
driver properties. The DriverManager was buried in DBConfiguration. I created
a jobconf prefix "dbmigrate.driver." that lets you set arbitrary configuration values
in the job conf that will be used as driver properties. I then added convenience
methods all the way up to DBMigrateTap / DBOptions supporting class.
In clojure, we can now do something like this:
(let [opts (new cascading.dbmigrate.tap.DBMigrateTap$Options)](set! %28. opts :minId%29 %28long min%29))
(set! (. opts :maxId) (long max)))
(set! (. opts :driverProps) {"oracle.jdbc.J2EE13Compliant" "true"})
opts))
you should also be able to add
{"dbmigrate.driver.oracle.jdbc.J2EE13Compliant" "true"}
to your job-conf.clj file if you choose.