Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep 5 seconds after status checks are done #131

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Conversation

gao-sun
Copy link
Contributor

@gao-sun gao-sun commented Jul 8, 2022

We ran into a random issue that even if the desired checks are successfully done, the action reports one of them is still in progress.

image

Usually a re-run would solve it, so I'd like to give GitHub Actions 5 more seconds to ensure status has been synced.

@CasperWA
Copy link
Owner

This is strange, as the check whether any status checks are finished is done through the GitHub REST API - hence it should already by synced, since I'm guessing this is the internals GitHub is also asking when trying to check whether required status checks are finished or not.

But I don't mind putting in this buffer. I might make it an input variable though, similar to the current sleep input variable, which is essentially for the same thing, but prior to starting the whole action than after.

Copy link
Owner

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this in as is - removing the white-space. Then I'll update the code, making this a user input. In between I'll create a patch release, updating the v2 tag.
If you have time in between these updates, please test that this actually solves your issue.

entrypoint.sh Outdated Show resolved Hide resolved
@CasperWA CasperWA enabled auto-merge (squash) July 11, 2022 10:07
@CasperWA CasperWA merged commit 9fffeb6 into CasperWA:main Jul 11, 2022
@gao-sun gao-sun deleted the patch-1 branch July 17, 2022 04:23
@gao-sun
Copy link
Contributor Author

gao-sun commented Jul 17, 2022

Thank you! It do works fine with v2 tag.

https://github.com/logto-io/logto/actions/workflows/publish.yml

@gao-sun
Copy link
Contributor Author

gao-sun commented Jul 17, 2022

I think it's more like a data sync issue of GitHub, thanks again for the effort.

@CasperWA
Copy link
Owner

I think it's more like a data sync issue of GitHub, thanks again for the effort.

Indeed, I think the same. I'll still work towards making this a user input, so that if GitHub should be especially troubled at times it can be changed to adapt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants