Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pat::Match and related #15

Closed
wants to merge 1 commit into from

Conversation

CasualX
Copy link
Owner

@CasualX CasualX commented Jan 13, 2018

This API was originally required to make the pattern scanner work with the Iterator trait (you cannot put the result of the iteration inside the iterator object, aka streaming iterator).

However this required that the returned object either had a fixed size (pat::MAX_SAVE) or a dynamically allocated Vec. So I went with pat::Match, a fixed length result object.

Since I've decided to drop the Iterator trait, the above workaround is no longer necessary and I would like to get rid of it.

Unfortunately #[deprecated] is very noisy so I expect this PR to remain until something changes, see rust-lang/rust#47219 and others.

@CasualX CasualX force-pushed the features/patterns-deprecations branch from c020c19 to a5b754e Compare March 7, 2018 20:39
@CasualX CasualX force-pushed the features/patterns-deprecations branch from a5b754e to dbc6ef2 Compare August 4, 2018 16:59
@CasualX
Copy link
Owner Author

CasualX commented Aug 23, 2018

I'm going to close this because #[deprecated] is just too noisy, perhaps I should just remove it. This API can be reintroduced when streaming iterators are in std.

@CasualX CasualX closed this Aug 23, 2018
@CasualX CasualX deleted the features/patterns-deprecations branch August 23, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant