Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API was originally required to make the pattern scanner work with the
Iterator
trait (you cannot put the result of the iteration inside the iterator object, aka streaming iterator).However this required that the returned object either had a fixed size (
pat::MAX_SAVE
) or a dynamically allocated Vec. So I went withpat::Match
, a fixed length result object.Since I've decided to drop the
Iterator
trait, the above workaround is no longer necessary and I would like to get rid of it.Unfortunately
#[deprecated]
is very noisy so I expect this PR to remain until something changes, see rust-lang/rust#47219 and others.