-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Off by one error on recurring days reminder? #64
Comments
Do you have your locale settings set up in such way that Sunday is considered the first day of the week? Also, what is the locale you set in the settings of MIND? |
environment variable was correct, but the Mind settings were possibly the issue. I guess either I set it wrong or it defaulted to "en-gb". I updated it to "en-us" I'll test and see if it works for the entire week. Thanks! |
The default is en-GB yes. What I think is happening is that somewhere on your system (os? Browser? Docker?) a locale is used that considers Sunday to be the first day of the week instead of Monday. MIND doesn't handle that and, without getting too technical, that's why the set days are shifted by one; the beginning of the week is also shifted by one day. |
I changed the computer Mind is running on to start Monday, deleted DB and spun the container back up, did not fix. I tried Chrome, Opera, Firefox and Edge browsers on Windows after changing the date on my Windows machine and that did not work. I also tried Firefox on the Linux machine. All after removing the Mind container. Any other options I may be missing? |
A bug in my software. I'm not sure what's going wrong yet, but it looks like it's a bug in my software then. |
@joestump, @rossman-home, Could one of you do something for me? I want to determine if the problem lays in the frontend or backend.
Note: the value of the In the image you can see that I've opened the red "Test1" reminder in the results in the Preview tab. It says for the weekdays |
@joestump @rossman-home please see my previous comment |
I'm pretty sure I'm having the same issue here. I create a reminder for Monday, April 8, 2024, at 8:00 AM (first screenshot). When I save it, it shows Monday, April 15, 2024, but for each Sunday (second screenshot). The third screenshot is the steps from your request to view the request in the browser. My PC is on New York time (Eastern), the Docker host (Ubuntu 22.04) is on New York time, and I've set the TZ on the MIND Docker to New York. I verified time zones using a website that shows browser TZ on Ubuntu by running the timedatectl and date commands and within the docker by running "docker exec -it mind date". I've tried Firefox, Edge, and Chrome, and I've also tried private/incognito tabs in each. I'm the image: mrcas/mind:latest image. |
Just as another test, I manually deployed to a Windows host using localhost:8080. I get the same issue: a repeating reminder for Monday, April 8, 2024, at 8:00 AM saves as Monday, April 15, 2024, at 8:00 AM but says Each Sunday. |
Thanks for doing the browser thing. Based on the screenshot, I can say that the wrong weekday is purely in the browser and the actual reminder will run on Monday. On my PC, day 0 converts to Monday, but in your screenshot, day 0 converts to Sunday. So it's purely the browser converting the day of the week wrong (it sees Sunday as the first day of the week). Probably something with localisation. And I think I found the problem of the first trigger being one week later. |
Description of the bug
When creating recurring reminders on specific days I'm seeing an off-by-one error when selecting days vs. what the reminder dashboard shows on save. If I select "Mo", on save it shows "Sun" after save on the dashboard.
To Reproduce
Expected behaviour
When I select "Mo"
Screenshots
You can see in this screen recording what I'm seeing with the "Test" reminder:
Screen.Recording.2023-11-10.at.2.24.29.PM.mov
Version info
mrcas/mind:latest
The text was updated successfully, but these errors were encountered: