-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Project C.A.T.S." code #117
Conversation
Current "Project C.A.T.S." backers won't be affected by this change Signed-off-by: Tomáš Taro <tomas@getadblock.com>
@kpeckett Please, take a look and review. You can compare changes in this PR against 44ca859. Thanks! :) |
Question: |
Disabled by default Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
@kpeckett For new users, I've added "The Cats Of Project CATS" channel, which is disabled by default. Could you review again? Thanks :) |
I'm still unsure why we're removing it. How much does including it affect the install time? |
@kpeckett We have to open our install page right after installation of CatBlock, in order to determine, whether CatBlock should activate "Project C.A.T.S." channel or not. |
@tomasko126 and that's bad because...? I'm sure there's a good reason, I'm just not sure what it is |
@kpeckett Because it takes additional ~30 seconds of extension load. If user, who has just installed CatBlock closes our install page, CatBlock may end up in an uninitialised state and that's the second reason :) On the other side I implemented "Project C.A.T.S." channel, which is disabled by default but can be enabled (only for new users). |
installing. This change is required by CatBlock/catblock#117
Current "Project C.A.T.S." backers won't be affected by this change