Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Project C.A.T.S." code #117

Merged
merged 5 commits into from
Jan 14, 2017
Merged

Remove "Project C.A.T.S." code #117

merged 5 commits into from
Jan 14, 2017

Conversation

tomasko126
Copy link
Member

Current "Project C.A.T.S." backers won't be affected by this change

Current "Project C.A.T.S." backers won't be affected by this change

Signed-off-by: Tomáš Taro <tomas@getadblock.com>
@tomasko126
Copy link
Member Author

@kpeckett Please, take a look and review.
Current backers won't be affected by this change.

You can compare changes in this PR against 44ca859.

Thanks! :)

@tomasko126 tomasko126 requested a review from itskdog January 12, 2017 19:04
@tomasko126 tomasko126 changed the title Remove "Project C.A.T.S. code" Remove "Project C.A.T.S." code Jan 12, 2017
@itskdog
Copy link
Member

itskdog commented Jan 12, 2017

Question:
What if C.A.T.S. backers wish to install their version on another computer, but keep the C.A.T.S. images. If they install through /project-cats again, they won't get the images they had before, would they still get the images they backed for?

@itskdog itskdog assigned tomasko126 and unassigned itskdog Jan 12, 2017
tomasko126 and others added 3 commits January 13, 2017 13:50
Disabled by default

Signed-off-by: Tomáš Taro <tomas@getadblock.com>
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
@tomasko126 tomasko126 assigned itskdog and unassigned tomasko126 Jan 13, 2017
@tomasko126
Copy link
Member Author

@kpeckett For new users, I've added "The Cats Of Project CATS" channel, which is disabled by default. Could you review again? Thanks :)

@itskdog
Copy link
Member

itskdog commented Jan 14, 2017

I'm still unsure why we're removing it. How much does including it affect the install time?

@tomasko126
Copy link
Member Author

@kpeckett We have to open our install page right after installation of CatBlock, in order to determine, whether CatBlock should activate "Project C.A.T.S." channel or not.

@itskdog
Copy link
Member

itskdog commented Jan 14, 2017

@tomasko126 and that's bad because...? I'm sure there's a good reason, I'm just not sure what it is

@tomasko126
Copy link
Member Author

@kpeckett Because it takes additional ~30 seconds of extension load. If user, who has just installed CatBlock closes our install page, CatBlock may end up in an uninitialised state and that's the second reason :) On the other side I implemented "Project C.A.T.S." channel, which is disabled by default but can be enabled (only for new users).

@tomasko126 tomasko126 merged commit 5137cce into master Jan 14, 2017
@tomasko126 tomasko126 deleted the remove-project-cats branch January 14, 2017 15:39
@tomasko126 tomasko126 modified the milestone: 1.5 Jan 14, 2017
itskdog added a commit to CatBlock/catblock.github.io that referenced this pull request Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants