Update jQuery to the v3.1 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
|
Have you run the (non-minified) migrate plugin to check for jQuery API changes that are unsupported since the previous version we used? |
|
@kpeckett Good point, I will include jQuery Migrate plugin in my tests and will change the deprecated code, where applicable. |
Signed-off-by: Tomáš Taro <tomas@getadblock.com>
|
@kpeckett Ready to review :) |
|
Were these the only changes needed? Did you check the BG page, content script, options pages + other pages (e.g. resourcelist, adreport, popup, .etc) |
|
@kpeckett Yep, I checked every page. |
itskdog
approved these changes
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomáš Taro tomas@getadblock.com
@kpeckett Could you review?
Thanks :)