Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename App.Handler to App.That #242

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

This commit adjusts the App.Handler to App.That and removes the App.HasHandler property. Because this property is no longer necessary

@ymh199478 ymh199478 mentioned this pull request Jun 15, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jun 15, 2019

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          37       37           
  Lines        2495     2495           
=======================================
  Hits         2436     2436           
  Misses         59       59
Impacted Files Coverage Δ
src/CatLib.Core/CatLib/Application.cs 99.31% <100%> (ø) ⬆️
src/CatLib.Core/Container/BindData.cs 100% <0%> (ø) ⬆️
src/CatLib.Core/Container/Container.cs 99.67% <0%> (ø) ⬆️
src/CatLib.Core/Container/GivenData.cs 100% <0%> (ø) ⬆️
src/CatLib.Core/Container/MethodContainer.cs 100% <0%> (ø) ⬆️
src/CatLib.Core/Container/ExtendBindData.cs 100% <0%> (ø) ⬆️
src/CatLib.Core/CatLib/Facade.cs 94.87% <0%> (ø) ⬆️
src/CatLib.Core/Container/ExtendContainer.cs 100% <0%> (ø) ⬆️
src/CatLib.Core/EventDispatcher/EventDispatcher.cs 96.49% <0%> (ø) ⬆️
src/CatLib.Core/Container/Bindable.cs 98.14% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c096ecb...61d682b. Read the comment docs.

@ymh199478 ymh199478 merged commit 517122d into master Jun 15, 2019
@ymh199478 ymh199478 deleted the changed/free-handler-rename-to-that branch June 25, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants