Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CodeStandardException. #257

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed Yes
Tests pass? No
Doc pr? No

The commit removed the code standard exception, please use LogicException instead.

Because we found that the definition of CodeStandardException is not clear.

@ymh199478 ymh199478 mentioned this pull request Jul 20, 2019
55 tasks
@codecov-io
Copy link

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          35       35           
  Lines        2401     2401           
=======================================
  Hits         2166     2166           
  Misses        235      235
Impacted Files Coverage Δ
src/CatLib.Core/CatLib/Application.cs 98.07% <100%> (ø) ⬆️
src/CatLib.Core/Container/Container.cs 96.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef1e08...fee9081. Read the comment docs.

@ymh199478 ymh199478 merged commit 9268aa0 into master Jul 20, 2019
@ymh199478 ymh199478 deleted the changed/free-code-stdandard-exception branch July 23, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants