Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor event system. #262

Merged
merged 1 commit into from
Jul 27, 2019
Merged

refactor event system. #262

merged 1 commit into from
Jul 27, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes(#177 )
Removed No
Tests pass? Yes
Doc pr? No

Submit redesigned interface to avoid using generics

@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #262 into master will decrease coverage by 0.1%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   90.23%   90.13%   -0.11%     
==========================================
  Files          35       36       +1     
  Lines        2397     2403       +6     
==========================================
+ Hits         2163     2166       +3     
- Misses        234      237       +3
Impacted Files Coverage Δ
...rc/CatLib.Core/CatLib/Events/AfterBootEventArgs.cs 100% <ø> (ø) ⬆️
...tLib.Core/CatLib/Events/StartCompletedEventArgs.cs 100% <ø> (ø) ⬆️
...tLib.Core/CatLib/Events/AfterTerminateEventArgs.cs 100% <ø> (ø) ⬆️
...CatLib.Core/CatLib/Events/InitProviderEventArgs.cs 75% <ø> (ø) ⬆️
src/CatLib.Core/CatLib/Events/BootingEventArgs.cs 100% <ø> (ø) ⬆️
...ib.Core/CatLib/Events/RegisterProviderEventArgs.cs 100% <ø> (ø) ⬆️
...c/CatLib.Core/CatLib/Events/BeforeInitEventArgs.cs 100% <ø> (ø) ⬆️
.../CatLib.Core/CatLib/Events/ApplicationEventArgs.cs 100% <ø> (ø) ⬆️
...rc/CatLib.Core/CatLib/Events/AfterInitEventArgs.cs 100% <ø> (ø) ⬆️
...c/CatLib.Core/CatLib/Events/BeforeBootEventArgs.cs 66.66% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc374c9...d657f53. Read the comment docs.

@ymh199478 ymh199478 merged commit dbdbfd6 into master Jul 27, 2019
@ymh199478 ymh199478 deleted the refactor/event-system branch July 27, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants