Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed App.Version. #266

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Removed App.Version. #266

merged 1 commit into from
Jul 27, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

This commit removed the App.Version, Please use Application.Version directly

@ymh199478 ymh199478 mentioned this pull request Jul 27, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          36       36           
  Lines        2445     2445           
=======================================
  Hits         2187     2187           
  Misses        258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2cb34...54b204d. Read the comment docs.

@ymh199478 ymh199478 merged commit eb4aa6b into master Jul 27, 2019
@ymh199478 ymh199478 deleted the removed/app-version branch August 4, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants