Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed global params in application constructor. #267

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

this commit removed global params in application constructor. use Application.New() instead.

@ymh199478 ymh199478 mentioned this pull request Jul 27, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #267 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   89.44%   89.45%   +<.01%     
==========================================
  Files          36       36              
  Lines        2445     2446       +1     
==========================================
+ Hits         2187     2188       +1     
  Misses        258      258
Impacted Files Coverage Δ
src/CatLib.Core/CatLib/Application.cs 96.74% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4aa6b...7330064. Read the comment docs.

@ymh199478 ymh199478 merged commit a7429f6 into master Jul 28, 2019
@ymh199478 ymh199478 deleted the changed/free-constructor-application branch August 4, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants