Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container is not thread-safe by default. #270

Merged
merged 1 commit into from
Aug 4, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

Containers are no longer thread-safe by default. Because in most cases we don't need thread safety, and existing thread safety can make the code messy.

@ymh199478 ymh199478 mentioned this pull request Aug 4, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Aug 4, 2019

Codecov Report

Merging #270 into master will decrease coverage by 0.29%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #270     +/-   ##
=========================================
- Coverage   89.43%   89.13%   -0.3%     
=========================================
  Files          36       36             
  Lines        2432     2366     -66     
=========================================
- Hits         2175     2109     -66     
  Misses        257      257
Impacted Files Coverage Δ
src/CatLib.Core/Container/BindData.cs 94.11% <100%> (-0.89%) ⬇️
src/CatLib.Core/Container/MethodContainer.cs 90.74% <87.5%> (-1.57%) ⬇️
src/CatLib.Core/Container/Bindable.cs 95.45% <95%> (-0.78%) ⬇️
src/CatLib.Core/Container/Container.cs 96.07% <98.29%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56610f8...69e5c54. Read the comment docs.

@ymh199478 ymh199478 merged commit 759b67e into master Aug 4, 2019
@ymh199478 ymh199478 deleted the changed/free-thread-safe branch August 4, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants