Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode-test setup and add CI job #43

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Fix vscode-test setup and add CI job #43

merged 5 commits into from
Oct 29, 2024

Conversation

rprimet
Copy link
Contributor

@rprimet rprimet commented Oct 21, 2024

The current vscode-test stub was broken by the use of p-queue (promise queue, a dependency when implementing the "run test" feature).

The current p-queue is not compatible with commonjs2 builds, which we use.

This PR pins p-queue to 6.6.2, which is the last version that supports a commonjs build, and adds a CI job that runs vscode-test

Ultimately we should use ESM for packaging our plugin but the support for this in vscode is still not yet completely mature (?) -- see for instance microsoft/vscode#130367 and https://code.visualstudio.com/updates/v1_94#_esm-is-shipping-for-vs-code

…CommonJS (unfortunately VS code still seems to require CJS for extensions)
@rprimet rprimet marked this pull request as ready for review October 28, 2024 09:37
@rprimet
Copy link
Contributor Author

rprimet commented Oct 28, 2024

@AltGr if you have comments about the CI setup for opam/dune those are welcome!

Also I added atdgen as a dependency which may not be ideal? (maybe atdgen_runtime should be a runtime dependency and atdgen a build-time only dependency?)

@rprimet rprimet marked this pull request as draft October 28, 2024 09:59
@rprimet rprimet marked this pull request as ready for review October 28, 2024 10:00
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rprimet rprimet merged commit f079c08 into master Oct 29, 2024
1 check passed
@rprimet rprimet deleted the fix_test_add_ci branch October 29, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants