Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@sarath-p
Copy link
Contributor

Copy link
Collaborator

@dennisseah dennisseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to consider the fact that spk (command line tool for bedrock) is just a part of bedrock. My concern is that having spk source at the root of the repo may hinder addition of source code of future sub components, maybe we have other tools like visualization, diagnostics, etc. Since spk is just a command line tool, we should consider having its src code under a subfolder like cmdline.

Making this kind of repo changes create a lot of inconvenience; and we hope that we do not have to do it often. Hence it is important to look ahead to the future and foresee future needs.

Just my 2 cents worth.

@sarath-p
Copy link
Contributor Author

@dennisseah - i think we still need to decide mono-repo vs. multi-repo by looking at the pros and cons of each approach. Your comment is based on mono-repo where you can have other Bedrock related projects in a single repo vs. having them in separate repos. Few things to consider are, opening multi-repo in VS Code even though most of the time engineers work in a single area. Also, are these binaries will have the same release/version or different? The build/release process can be handles by the build process in mono-repo scenario. The current model is based on multi-repo, but we can organize it to mono-repo if that is the best option.

@sarath-p sarath-p changed the title Proposal to merge spk repo into bedrock with phased approach Phase 1 documentation for moving spk repo into bedrock with phased approach Mar 20, 2020
@sarath-p sarath-p requested a review from dennisseah March 20, 2020 17:35
@andrebriggs
Copy link
Collaborator

@sarath-p does the file src/commands/deployment/dashboard.test.ts need to change?

@sarath-p
Copy link
Contributor Author

@sarath-p does the file src/commands/deployment/dashboard.test.ts need to change?

It was an error in commits. Reverted back the file to master branch version.

Copy link
Collaborator

@NathanielRose NathanielRose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarath-p sarath-p merged commit fa9eaf8 into master Mar 23, 2020
@sarath-p sarath-p deleted the repomerge branch March 23, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create list of changes in SPK and Bedrock respective repos to do before merge

5 participants