-
Notifications
You must be signed in to change notification settings - Fork 16
Phase 1 documentation for moving spk repo into bedrock with phased approach
#399
Conversation
Merging Phase 1 and 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we need to consider the fact that spk (command line tool for bedrock) is just a part of bedrock. My concern is that having spk source at the root of the repo may hinder addition of source code of future sub components, maybe we have other tools like visualization, diagnostics, etc. Since spk is just a command line tool, we should consider having its src code under a subfolder like cmdline.
Making this kind of repo changes create a lot of inconvenience; and we hope that we do not have to do it often. Hence it is important to look ahead to the future and foresee future needs.
Just my 2 cents worth.
|
@dennisseah - i think we still need to decide mono-repo vs. multi-repo by looking at the pros and cons of each approach. Your comment is based on mono-repo where you can have other Bedrock related projects in a single repo vs. having them in separate repos. Few things to consider are, opening multi-repo in VS Code even though most of the time engineers work in a single area. Also, are these binaries will have the same release/version or different? The build/release process can be handles by the build process in mono-repo scenario. The current model is based on multi-repo, but we can organize it to mono-repo if that is the best option. |
spk repo into bedrock with phased approachspk repo into bedrock with phased approach
|
@sarath-p does the file |
It was an error in commits. Reverted back the file to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes microsoft/bedrock#1125
Related to microsoft/bedrock#1073