Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@mtarng
Copy link
Collaborator

@mtarng mtarng commented Mar 20, 2020

Closes microsoft/bedrock#1134

Additionally, added changes so if the lifecycle pipeline runs and there are no changes, it will no longer push a branch and open a PR with no file changes.

Also moved helm version to be a constant

Copy link
Member

@bnookala bnookala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only thought is that im wondering if we should preserve indentation in logical statements, but otherwise lg2m

@mtarng
Copy link
Collaborator Author

mtarng commented Mar 20, 2020

@bnookala I thought about it, but because the script is stored in YAML, i'm afraid that may break the script/pipeline definition.

@mtarng mtarng merged commit fc56b19 into master Mar 20, 2020
@mtarng mtarng deleted the pipeline-commit-bug branch March 20, 2020 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lifecycle pipeline will "fail" (error) if commits happen on a single app repo where service is in root

4 participants