This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Better error message in spk project #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisseah
reviewed
Mar 31, 2020
src/lib/i18n.json
Outdated
| "project-err-spk-config-missing": "SPK Config is missing", | ||
| "project-err-invalid-options": "Invalid option values", | ||
| "project-err-pipeline-create": "Error occurred during pipeline creation for {0}", | ||
| "project-err-invalid-build-definition": "Invalid BuildDefinition created, parameter 'id' is missing from {0}", |
Collaborator
There was a problem hiding this comment.
can you replace project-err-... with project-install-life-cycle-pipeline-err..., in this manner, the key in this i18n file will be unique. and it hope to keep the <command>-<sub-command>- convention. project-err-... is too board.
added 3 commits
March 31, 2020 16:03
dennisseah
approved these changes
Apr 1, 2020
samiyaakhtar
approved these changes
Apr 1, 2020
added 2 commits
April 1, 2020 10:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue.