This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Fix repository name not populated #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiyaakhtar
approved these changes
Apr 2, 2020
mtarng
suggested changes
Apr 2, 2020
src/commands/project/pipeline.ts
Outdated
| // values are validate, adding || "" is just to | ||
| // satisfy the no-non-null-assertion eslint rule | ||
| const configVals: ConfigValues = { | ||
| orgName: opts.orgName || "", |
There was a problem hiding this comment.
This whole logic section is kinda confusing. Why are we still loading from opts from here. Shouldn't all of these be loaded from the values object instead?
This was introduced in: https://github.com/CatalystCode/spk/pull/479/files
@edaena @dennisseah does this make sense for us to fix this all here? Does similar logic for other ConfigValues interfaces exist now too in other commands?
There was a problem hiding this comment.
@mtarng do you know other places that this problem too?
There was a problem hiding this comment.
I'm not sure, which is why I asked the question @dennisseah . Have we refactored any other commands to move arguments from CommandOptions to ConfigValues?
dennisseah
approved these changes
Apr 2, 2020
mtarng
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository name is not part of the supported "opts"