Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[FEATURE] added error code for setup command related libs #498

Merged
merged 20 commits into from
Apr 6, 2020
Merged

[FEATURE] added error code for setup command related libs #498

merged 20 commits into from
Apr 6, 2020

Conversation

@dennisseah
Copy link
Collaborator

@dennisseah dennisseah commented Apr 2, 2020 •
edited
Loading

@dennisseah dennisseah mentioned this pull request Apr 6, 2020
Closed
@samiyaakhtar
Copy link
Collaborator

samiyaakhtar commented Apr 6, 2020

Since this is a very large PR, let's get some more eyes on this

@samiyaakhtar samiyaakhtar requested a review from bnookala April 6, 2020 18:28
@dennisseah
Copy link
Collaborator Author

dennisseah commented Apr 6, 2020

ran ./validation.sh

Successful build for pipeline: fabrikam-hld-to-fabrikam-manifests-399!
info:    Generating config.yaml from yaml file input.
info:    config.yaml was generated and located at /Users/veseah/.spk/config.yaml.
info:    Successfully initialized the spk tool!
Start Time           Service      Deployment   Commit  Src to ACR Image Tag                                             Result ACR to HLD Env    Hld Commit Result HLD to Manifest Result
4/6/2020, 1:08:08 PM fabrikam2019 e20c16f3fdad ffb55f4 627        fabrikam2019-fabrikam.acme.frontend:master-20200406.1 ✓      627        MASTER 6bc49cc    ✓      628             ✓     
1 deployment(s) were returned by spk deployment get
Verified that srcPipeline:627 acrPipelineId:627 hldPipelineId:628 pullrequest:"320" are all linked together correctly.
Successfully reached the end of spk deployment get tests.

@dennisseah dennisseah merged commit 5cbb60c into master Apr 6, 2020
@dennisseah dennisseah deleted the lib1294 branch April 6, 2020 20:34
@samiyaakhtar samiyaakhtar restored the lib1294 branch April 6, 2020 20:36
@dennisseah dennisseah deleted the lib1294 branch April 6, 2020 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@edaena edaena Awaiting requested review from edaena

@evanlouie evanlouie Awaiting requested review from evanlouie

@mtarng mtarng Awaiting requested review from mtarng

@sarath-p sarath-p Awaiting requested review from sarath-p

@NathanielRose NathanielRose Awaiting requested review from NathanielRose

@yradsmikham yradsmikham Awaiting requested review from yradsmikham

@bnookala bnookala Awaiting requested review from bnookala

2 more reviewers

@samiyaakhtar samiyaakhtar samiyaakhtar approved these changes

@andrebriggs andrebriggs andrebriggs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI setup command give 401 error with incorrect PAT

4 participants

@dennisseah @samiyaakhtar @andrebriggs