Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@dennisseah
Copy link
Collaborator

closes microsoft/bedrock#1312

added inherit properties to command decorator json file and use
populateInheritValueFromConfig and validateForRequiredValues functions to inherit values from config.xml and check that all mandatory options have values respectively. hence removing code of performing the above tasks in `create-revision.ts file

@yradsmikham yradsmikham self-requested a review April 6, 2020 21:05
@dennisseah
Copy link
Collaborator Author

ran validation test

pipeline_status this iteration --> "completed"
Successful build for pipeline: fabrikam-hld-to-fabrikam-manifests-405!
info:    Generating config.yaml from yaml file input.
info:    config.yaml was generated and located at /Users/veseah/.spk/config.yaml.
info:    Successfully initialized the spk tool!
Start Time           Service      Deployment   Commit  Src to ACR Image Tag                                             Result ACR to HLD Env    Hld Commit Result HLD to Manifest Result
4/6/2020, 2:45:18 PM fabrikam2019 9ad833e667c1 512a3ea 645        fabrikam2019-fabrikam.acme.frontend:master-20200406.1 ✓      645        MASTER f407fdb    ✓      646             ✓     
1 deployment(s) were returned by spk deployment get
Verified that srcPipeline:645 acrPipelineId:645 hldPipelineId:646 pullrequest:"330" are all linked together correctly.
Successfully reached the end of spk deployment get tests.

@dennisseah dennisseah merged commit 933746d into master Apr 6, 2020
@dennisseah dennisseah deleted the issue1312 branch April 6, 2020 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify inheritance of option values for service create revision command

4 participants