[BUG FIX] add proper error message when PAT is incorrect.

[dennisseah]

closes: microsoft/bedrock#1281

this is what we get when PAT is incorrect

code: 1000
message: setup-cmd-failed: Setup command was not successfully executed.
  code: 1400
  message: setup-cmd-core-api-err: Could not get Core API client. Check the Azure credential.
  details: Failed request: (401)

[mtarng]

Core API is also for Azure DevOps. Let's be specific so we don't confuse the user between Azure and Azure DevOps here.

[dennisseah]

can you suggest a good message? thanks

[mtarng]

The same message as the other errors:

Something like
Could not initialize Core API client. Check the Azure DevOps credentials.

This is just being explicit about Azure vs Azure DevOps

[dennisseah]

actually, this one is for Azure and not Azure DevOps. the other 2 are for Azure DevOps. We are using PAT to authenticate for this one and using Service Principal for the other 2.

[dennisseah]

integration test results

fabrikam-hld-to-fabrikam-manifests has pipeline id of 423
Get the build status for build...
pipeline: fabrikam-hld-to-fabrikam-manifests-423:
pipeline_status this iteration --> "completed"
Successful build for pipeline: fabrikam-hld-to-fabrikam-manifests-423!
info:    Generating config.yaml from yaml file input.
info:    config.yaml was generated and located at /Users/veseah/.spk/config.yaml.
info:    Successfully initialized the spk tool!
Start Time           Service      Deployment   Commit  Src to ACR Image Tag                                             Result ACR to HLD Env    Hld Commit Result HLD to Manifest Result
4/6/2020, 8:17:28 PM fabrikam2019 51fb5e6d1b4f 52eebd5 711        fabrikam2019-fabrikam.acme.frontend:master-20200407.1 ✓      711        MASTER 4d88c1f    ✓      712             ✓     
1 deployment(s) were returned by spk deployment get
Verified that srcPipeline:711 acrPipelineId:711 hldPipelineId:712 pullrequest:"368" are all linked together correctly.
Successfully reached the end of spk deployment get tests.